Plugin: drop login, logout, isrc-backfill, isrc-submit (out of scope per SPEC) #22
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
SPEC.md §2 (out of scope), §5, and §12 remove these features from the first release. They are currently implemented in
beetsplug/appleplaylists/__init__.py(_login,_logout,_backfill,_submit),isrc.py, and parts ofsync.py.Task
loginandlogoutsubcommands: the plugin must not open browsers, poll the login flow, or clear the Apple session. Apple-session management belongs to the gateway's browser UI.isrc-backfillandisrc-submitand deletebeetsplug/appleplaylists/isrc.py(MusicBrainz client,IsrcSubmission).backfill_isrcsand the--write-tagsoption fromsync.py— the plugin never writes audio-file tags.isrc.*andplaylist_databaseconfig blocks that only served these commands.Note: the ISRC write rule (fill empty local
isrcon association) survives — it moves into the matching/matchwork, not this issue.Acceptance criteria
beet appleoffers only the SPEC command set.--write-tags, or login-polling remains.Ref: SPEC.md §2, §12.
Implemented in
coop/beets-appleplaylistsonmain:4937fad— removed thelogin,logout,isrc-backfill, andisrc-submitcommand paths, browser polling, MusicBrainz client, audio-tag backfill helper, related options, andisrc.py.d2d69a5— removed the obsoleteplaylist_databaseplugin configuration and documented playlistmanager configuration as the sole database source.Verification:
pytest -q: 20 passedpython -m compileall -q beetsplug tests: passed--write-tags, or backfill references remain in plugin code.The full
beetCLI smoke check was blocked by the host missinglibstdc++.so.6; plugin-level tests and compilation pass.Implementation is pushed in
4937fadandd2d69a5, but issue 22 is reopened becauseAGENTS.mdcould not be updated: Hermes protects agent-instruction files and the edit approval prompt timed out. The file still mentionsbeet apple loginandbeetsplug/appleplaylists/isrc.py; no such references remain in plugin code or the README. A user-approved/manual edit ofAGENTS.mdis still required to satisfy the documentation acceptance item.Delivered in merged PR #36 (
cb442af). Issue-specific implementation commits:4937fad(completed by the SPEC-aligned documentation in02d5954)1e245f29186be50a8ae9702d5954Verification: 95 tests passed; focused Ruff checks, compileall, diff checks, isolated-
BEETSDIRcommand smoke testing, and package build all passed. Issue #34 remains open by maintainer request for the deferred real-library acceptance run.