Sync: preserve permanent skipped resolutions #37

New issue

Closed

opened 2026-09-05 20:37:39 +00:00 by hermes · 1 comment

hermes commented

2026-09-05 20:37:39 +00:00

Owner

Context

Post-merge review of PR #36 found that ordinary sync resolves every fetched track before consulting plugin state. A track marked skipped can therefore be automatically associated and changed to matched, contrary to SPEC.md §7.

Task

Preserve persisted permanent-skip decisions during ordinary and dry-run sync. Skipped tracks must not be offered to automatic matching, written to beets item metadata, or included in playlistmanager contents. Refreshing current membership and Apple descriptive metadata must not clear the skip.

Acceptance criteria

A regression test fails against current main and proves the bug.
Ordinary sync preserves resolution_state = skipped.
A valid automatic candidate remains unassociated and omitted from playlist contents.
Explicit beet apple match remains the only workflow that clears the skip.
Full tests and package/CLI validation pass.

## Context Post-merge review of PR #36 found that ordinary sync resolves every fetched track before consulting plugin state. A track marked `skipped` can therefore be automatically associated and changed to `matched`, contrary to `SPEC.md` §7. ## Task Preserve persisted permanent-skip decisions during ordinary and dry-run sync. Skipped tracks must not be offered to automatic matching, written to beets item metadata, or included in playlistmanager contents. Refreshing current membership and Apple descriptive metadata must not clear the skip. ## Acceptance criteria - [ ] A regression test fails against current `main` and proves the bug. - [ ] Ordinary sync preserves `resolution_state = skipped`. - [ ] A valid automatic candidate remains unassociated and omitted from playlist contents. - [ ] Explicit `beet apple match` remains the only workflow that clears the skip. - [ ] Full tests and package/CLI validation pass.

hermes referenced this issue from a commit

2026-09-05 20:38:31 +00:00

Plugin: preserve permanent skips during sync (#37)

hermes referenced this issue from a pull request that will close it,

2026-09-05 20:38:58 +00:00

Plugin: preserve permanent skips during sync #38

hermes referenced this issue

2026-09-05 20:40:47 +00:00

Acceptance: end-to-end validation against SPEC.md #34

hermes referenced this issue from a commit

2026-09-05 20:43:07 +00:00

Plugin: preserve permanent skips during sync (#37)

hermes closed this issue

2026-09-05 21:44:18 +00:00

hermes referenced this issue from a commit

2026-09-05 21:44:19 +00:00

Merge pull request: preserve permanent skips (#38)

hermes commented

2026-09-05 21:44:48 +00:00

Author

Owner

Completed in coop/beets-appleplaylists by implementation commit 20c72a5a93220c6b90b1dff89a4de82baca663d9, merged through PR #38 as ec5da9ee62f4f3b6bfcf6887e7f9e319ddedb8d5.

Regression coverage exercises both ordinary and dry-run sync. The final validation result was 97 tests passing with warnings promoted to errors, plus focused lint/format checks, compileall, isolated CLI help, package build, and git diff --check.

Completed in `coop/beets-appleplaylists` by implementation commit `20c72a5a93220c6b90b1dff89a4de82baca663d9`, merged through PR #38 as `ec5da9ee62f4f3b6bfcf6887e7f9e319ddedb8d5`. Regression coverage exercises both ordinary and dry-run sync. The final validation result was 97 tests passing with warnings promoted to errors, plus focused lint/format checks, compileall, isolated CLI help, package build, and `git diff --check`.