Add isolated integration coverage for the real playlistmanager store #50

New issue

Closed

opened 2026-09-05 22:42:26 +00:00 by tophattedcat · 0 comments

tophattedcat commented

2026-09-05 22:42:26 +00:00

Owner

Problem

Sync tests replace beetsplug.playlistmanager with a fake module. Its PlaylistStore factory ignores the database path, and PlaylistDatabaseError is substituted with RuntimeError.

These useful unit tests cannot detect constructor-side mutations, snapshot behavior, actual transaction semantics, exception mismatches, or changes to the public playlistmanager API.

Proposed change

Keep the fast fake-based tests and add a small integration suite using a supported real playlistmanager version and temporary databases. Document a reproducible way to install/run the integration dependency.

Acceptance criteria

Exercise existing-target lookup and replacement through the real public API.
Confirm order and duplicates are preserved and playlist metadata is unchanged.
Cover dry-run reads, including the SQLite snapshot strategy.
Exercise a meaningful real-store failure and verify correct error translation.
Use isolated BEETSDIR, library, and playlist databases; never access the user's global beets setup.
Keep gateway calls network-free.
Document the supported/tested playlistmanager version or revision.

References: tests/test_sync.py:24-48, beetsplug/appleplaylists/sync.py:65-71,99-108,193-194. Audit finding 9 (testing gap).

## Problem Sync tests replace beetsplug.playlistmanager with a fake module. Its PlaylistStore factory ignores the database path, and PlaylistDatabaseError is substituted with RuntimeError. These useful unit tests cannot detect constructor-side mutations, snapshot behavior, actual transaction semantics, exception mismatches, or changes to the public playlistmanager API. ## Proposed change Keep the fast fake-based tests and add a small integration suite using a supported real playlistmanager version and temporary databases. Document a reproducible way to install/run the integration dependency. ## Acceptance criteria - Exercise existing-target lookup and replacement through the real public API. - Confirm order and duplicates are preserved and playlist metadata is unchanged. - Cover dry-run reads, including the SQLite snapshot strategy. - Exercise a meaningful real-store failure and verify correct error translation. - Use isolated BEETSDIR, library, and playlist databases; never access the user's global beets setup. - Keep gateway calls network-free. - Document the supported/tested playlistmanager version or revision. References: `tests/test_sync.py:24-48`, `beetsplug/appleplaylists/sync.py:65-71,99-108,193-194`. Audit finding 9 (testing gap).

tophattedcat referenced this issue from a commit

2026-09-06 11:16:26 +00:00

Fix sync and local workflows (#44 #45 #46 #47 #48 #49 #50)

tophattedcat referenced this issue from a pull request that will close it,

2026-09-06 11:16:27 +00:00

Fix sync reliability and local workflows for #44–#50 #51

tophattedcat closed this issue

2026-09-06 13:54:54 +00:00