Build one sync plan for dry-run reporting and real execution #49

New issue

Closed

opened 2026-09-05 22:42:24 +00:00 by tophattedcat · 0 comments

tophattedcat commented

2026-09-05 22:42:24 +00:00

Owner

Problem

sync_playlists separately implements item-list construction, missing-track collection, counters, and change detection in dry-run and normal execution. Policy changes therefore need to be made twice.

Meanwhile _resolve_tracks performs persistent beets writes during what appears to be a calculation phase, making the boundary between planning and mutation difficult to audit.

Proposed change

Introduce a small, explicit desired-operation representation computed once. Dry-run renders that plan; execution applies it. Keep the abstraction proportionate to this plugin rather than introducing a general workflow framework.

Acceptance criteria

One path determines association decisions, desired item IDs, missing tracks, counters, memberships, and pruning intent.
Building the plan does not mutate beets, plugin state, or playlistmanager.
Dry-run output describes the same decisions real execution applies.
Preserve duplicate occurrences, skipped tracks, target validation, and independent-store failure recovery.
Add parity coverage for representative dry-run and execution scenarios.

References: beetsplug/appleplaylists/sync.py:26-47, sync.py:141-202. Audit finding 8 (maintainability). Related to batch matching and state transaction improvements, but focuses on shared planning/execution structure.

## Problem sync_playlists separately implements item-list construction, missing-track collection, counters, and change detection in dry-run and normal execution. Policy changes therefore need to be made twice. Meanwhile _resolve_tracks performs persistent beets writes during what appears to be a calculation phase, making the boundary between planning and mutation difficult to audit. ## Proposed change Introduce a small, explicit desired-operation representation computed once. Dry-run renders that plan; execution applies it. Keep the abstraction proportionate to this plugin rather than introducing a general workflow framework. ## Acceptance criteria - One path determines association decisions, desired item IDs, missing tracks, counters, memberships, and pruning intent. - Building the plan does not mutate beets, plugin state, or playlistmanager. - Dry-run output describes the same decisions real execution applies. - Preserve duplicate occurrences, skipped tracks, target validation, and independent-store failure recovery. - Add parity coverage for representative dry-run and execution scenarios. References: `beetsplug/appleplaylists/sync.py:26-47`, `sync.py:141-202`. Audit finding 8 (maintainability). Related to batch matching and state transaction improvements, but focuses on shared planning/execution structure.

tophattedcat referenced this issue from a commit

2026-09-06 11:16:26 +00:00

Fix sync and local workflows (#44 #45 #46 #47 #48 #49 #50)

tophattedcat referenced this issue from a pull request that will close it,

2026-09-06 11:16:27 +00:00

Fix sync reliability and local workflows for #44–#50 #51

tophattedcat closed this issue

2026-09-06 13:54:54 +00:00