Share ISRC canonicalization between matching and conflict reporting #47

New issue

Closed

opened 2026-09-05 22:42:20 +00:00 by tophattedcat · 0 comments

tophattedcat commented

2026-09-05 22:42:20 +00:00

Owner

Problem

MatchIndex canonicalizes ISRCs with upper() only. Reporting's isrcs_equal also removes hyphens. The same pair can therefore be considered equivalent in reporting while failing automatic ISRC matching.

Reproduced with local ISRC US-ABC-12-34567 and Apple ISRC USABC1234567, with different metadata to isolate ISRC matching: reporting equality was true and matching returned unmatched.

Proposed change

Define one ISRC canonicalization helper in a suitable shared policy module and use it for both index construction/lookups and conflict reporting. Canonicalization must not rewrite non-empty local metadata.

Acceptance criteria

Case and hyphen variants resolve consistently in matching and reporting.
Multiple items sharing the canonical ISRC remain ambiguous.
Missing ISRC behavior and local-metadata precedence remain unchanged.
Add a focused failing regression, then run matching/reporting and full tests.

References: beetsplug/appleplaylists/matching.py:94-95,111-120, reporting.py:43-56. Audit finding 6 (medium).

## Problem MatchIndex canonicalizes ISRCs with upper() only. Reporting's isrcs_equal also removes hyphens. The same pair can therefore be considered equivalent in reporting while failing automatic ISRC matching. Reproduced with local ISRC US-ABC-12-34567 and Apple ISRC USABC1234567, with different metadata to isolate ISRC matching: reporting equality was true and matching returned unmatched. ## Proposed change Define one ISRC canonicalization helper in a suitable shared policy module and use it for both index construction/lookups and conflict reporting. Canonicalization must not rewrite non-empty local metadata. ## Acceptance criteria - Case and hyphen variants resolve consistently in matching and reporting. - Multiple items sharing the canonical ISRC remain ambiguous. - Missing ISRC behavior and local-metadata precedence remain unchanged. - Add a focused failing regression, then run matching/reporting and full tests. References: `beetsplug/appleplaylists/matching.py:94-95,111-120`, `reporting.py:43-56`. Audit finding 6 (medium).

tophattedcat referenced this issue from a commit

2026-09-06 11:16:26 +00:00

Fix sync and local workflows (#44 #45 #46 #47 #48 #49 #50)

tophattedcat referenced this issue from a pull request that will close it,

2026-09-06 11:16:27 +00:00

Fix sync reliability and local workflows for #44–#50 #51

tophattedcat closed this issue

2026-09-06 13:54:54 +00:00