Batch playlist membership and resolution updates in one state transaction #45

New issue

Closed

opened 2026-09-05 22:42:16 +00:00 by tophattedcat · 0 comments

tophattedcat commented

2026-09-05 22:42:16 +00:00

Owner

Problem

Sync commits membership replacement and then calls set_resolution_state separately for every track occurrence. Each call starts its own transaction and changes updated_at, including duplicate occurrences and unchanged resolution values.

This causes unnecessary commits and leaves a playlist's state memberships and resolutions partially updated after a later failure within the same plugin database. Cross-store partial completion is expected by the spec; this additional fragmentation within one store is avoidable.

Proposed change

Provide a focused state-store operation that saves one playlist's memberships and unique-track resolution decisions together. Avoid redundant resolution updates while preserving Apple descriptor refresh and permanent skips.

Acceptance criteria

A failure while saving resolutions rolls back that playlist's plugin-state membership/resolution changes together.
Duplicate occurrences remain in memberships but do not trigger separate resolution commits.
Historical tracks and permanent skips are preserved.
Repeating the same desired sync remains idempotent.
Independent-store recovery and pruning semantics remain consistent with SPEC.md section 11.
Add focused transaction rollback and duplicate-occurrence tests.

References: beetsplug/appleplaylists/sync.py:177-191, state.py:127-161, state.py:228-255. Audit finding 4 (medium).

## Problem Sync commits membership replacement and then calls `set_resolution_state` separately for every track occurrence. Each call starts its own transaction and changes updated_at, including duplicate occurrences and unchanged resolution values. This causes unnecessary commits and leaves a playlist's state memberships and resolutions partially updated after a later failure within the same plugin database. Cross-store partial completion is expected by the spec; this additional fragmentation within one store is avoidable. ## Proposed change Provide a focused state-store operation that saves one playlist's memberships and unique-track resolution decisions together. Avoid redundant resolution updates while preserving Apple descriptor refresh and permanent skips. ## Acceptance criteria - A failure while saving resolutions rolls back that playlist's plugin-state membership/resolution changes together. - Duplicate occurrences remain in memberships but do not trigger separate resolution commits. - Historical tracks and permanent skips are preserved. - Repeating the same desired sync remains idempotent. - Independent-store recovery and pruning semantics remain consistent with SPEC.md section 11. - Add focused transaction rollback and duplicate-occurrence tests. References: `beetsplug/appleplaylists/sync.py:177-191`, `state.py:127-161`, `state.py:228-255`. Audit finding 4 (medium).

tophattedcat referenced this issue from a commit

2026-09-06 11:16:26 +00:00

Fix sync and local workflows (#44 #45 #46 #47 #48 #49 #50)

tophattedcat referenced this issue from a pull request that will close it,

2026-09-06 11:16:27 +00:00

Fix sync reliability and local workflows for #44–#50 #51

tophattedcat closed this issue

2026-09-06 13:54:54 +00:00