Plugin: drop auth.py and the PyJWT dependency #12

New issue

Closed

opened 2026-08-09 20:31:47 +00:00 by hermes · 1 comment

hermes commented

2026-08-09 20:31:47 +00:00

Owner

Context

Plugin rework (see #18). The plugin currently has a full Apple auth stack
(auth.py: ES256 signing + localhost MusicKit OAuth + credential cache).
After the gateway exists, none of it belongs on the beets host.

Task

In /opt/data/git/git.sams.wtf/coop/beets-appleplaylists (already cloned):

Delete beetsplug/appleplaylists/auth.py.
Remove PyJWT from pyproject.toml dependencies (and from the lockfile
via uv lock).
Remove the auth imports/usage from beetsplug/appleplaylists/__init__.py
— but note _sync/_backfill still call AppleAuthManager; complete
this only together with #13/#14 (they are one logical change; do them in
the same working session).
The MusicKit JS login HTML from auth.py is needed by the gateway —
it is preserved in git history and referenced by gateway issue #5; no
copy needs to live in the plugin.

Acceptance criteria

auth.py gone; PyJWT absent from pyproject.toml and uv.lock.
uv run pytest green after #13/#14 land.

## Context Plugin rework (see #18). The plugin currently has a full Apple auth stack (`auth.py`: ES256 signing + localhost MusicKit OAuth + credential cache). After the gateway exists, none of it belongs on the beets host. ## Task In `/opt/data/git/git.sams.wtf/coop/beets-appleplaylists` (already cloned): 1. Delete `beetsplug/appleplaylists/auth.py`. 2. Remove `PyJWT` from `pyproject.toml` dependencies (and from the lockfile via `uv lock`). 3. Remove the auth imports/usage from `beetsplug/appleplaylists/__init__.py` — but note `_sync`/`_backfill` still call `AppleAuthManager`; complete this only together with #13/#14 (they are one logical change; do them in the same working session). 4. The MusicKit JS login HTML from `auth.py` is needed by the gateway — it is preserved in git history and referenced by gateway issue #5; no copy needs to live in the plugin. ## Acceptance criteria - `auth.py` gone; `PyJWT` absent from `pyproject.toml` and `uv.lock`. - `uv run pytest` green after #13/#14 land.

hermes added the

plugin

label

2026-08-09 20:31:47 +00:00

hermes commented

2026-08-16 20:13:59 +00:00

Author

Owner

Implemented in coop/beets-appleplaylists commit b5a121c8c728bcf218e5e4561bed603e01e82b44:

deleted beetsplug/appleplaylists/auth.py;
removed PyJWT from pyproject.toml and regenerated uv.lock;
removed the old auth imports and credential dance from the plugin.

Verification: uv run pytest -q -> 21 passed; uv lock --check passed.

Implemented in `coop/beets-appleplaylists` commit `b5a121c8c728bcf218e5e4561bed603e01e82b44`: - deleted `beetsplug/appleplaylists/auth.py`; - removed `PyJWT` from `pyproject.toml` and regenerated `uv.lock`; - removed the old auth imports and credential dance from the plugin. Verification: `uv run pytest -q` -> 21 passed; `uv lock --check` passed.

hermes closed this issue

2026-08-16 20:14:00 +00:00